]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
gpiolib: sysfs: Do unexport GPIO when user asks for it
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 14 Aug 2023 11:26:15 +0000 (14:26 +0300)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 16 Aug 2023 11:34:31 +0000 (13:34 +0200)
commit20d9b3b5f2749673e1b5e9c8b0846ff6deff4032
tree0551da953cff983dde57ff9ceaa237f51527e1d2
parent2fc8d02058dbec258039c3253ebd1f124766a796
gpiolib: sysfs: Do unexport GPIO when user asks for it

It seems that sysfs interface implicitly relied on the gpiod_free() to
unexport the line. This is logically incorrect as core gpiolib should
not deal with sysfs so instead of restoring it, let's call
gpiod_unexport() from sysfs code.

Fixes: b0ce9ce408b6 ("gpiolib: Do not unexport GPIO on freeing")
Reported-by: Marek BehĂșn <kabel@kernel.org>
Closes: https://lore.kernel.org/r/20230808102828.4a9eac09@dellmb
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Marek BehĂșn <kabel@kernel.org>
[Bartosz: tweaked the commit message]
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpiolib-sysfs.c