]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
brcmsmac: make return of 0 explicit
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 19 May 2014 08:29:29 +0000 (10:29 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 19 May 2014 20:42:15 +0000 (16:42 -0400)
commit20e6f7f0437d6e1f2d459d5fc2ed1e242afcee16
tree40b077f8da34db07d8008165f0513d373497cc40
parent08232bf94949eabaabfcc2987025aed378aa13ae
brcmsmac: make return of 0 explicit

Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@

-ret = 0;
... when != ret = e
return
- ret
+ 0
  ;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[arend@broadcom.com: make brcms_b_detach() a void function]
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/brcm80211/brcmsmac/main.c