]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
xfs: don't update lastino for FSBULKSTAT_SINGLE
authorDarrick J. Wong <darrick.wong@oracle.com>
Sat, 6 Jul 2019 16:29:01 +0000 (09:29 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Sun, 7 Jul 2019 04:05:10 +0000 (21:05 -0700)
commit211bbf3c38ed90f43a3ec905e246014f96bceed7
tree9734cf84b0a87fb9b97833c7b100cbcebdcc0f73
parent036f463fe15db26c2d90724203e4a7ea8f9b8580
xfs: don't update lastino for FSBULKSTAT_SINGLE

The kernel test robot found a regression of xfs/054 in the conversion of
bulkstat to use the new iwalk infrastructure -- if a caller set *lastip
= 128 and invoked FSBULKSTAT_SINGLE, the bstat info would be for inode
128, but *lastip would be increased by the kernel to 129.

FSBULKSTAT_SINGLE never incremented lastip before, so it's incorrect to
make such an update to the internal lastino value now.

Fixes: 2810bd6840e463 ("xfs: convert bulkstat to new iwalk infrastructure")
Reported-by: kernel test robot <rong.a.chen@intel.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
fs/xfs/xfs_ioctl.c