]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
scsi: virtio_scsi: Use struct_size() helper
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 19 Jun 2019 19:28:33 +0000 (14:28 -0500)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 11 Jul 2019 20:06:39 +0000 (16:06 -0400)
commit211f70ff1daa3b3bb877f0f6fa85a42ef50f8341
tree1e5e0e63dfaea02cfe4e31ab3d09e22ee17a080c
parent169a126c6e88a99578a309a9021f314b5d532c5f
scsi: virtio_scsi: Use struct_size() helper

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct virtio_scsi {
...
        struct virtio_scsi_vq req_vqs[];
};

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

So, replace the following form:

sizeof(*vscsi) + sizeof(vscsi->req_vqs[0]) * num_queues

with:

struct_size(vscsi, req_vqs, num_queues)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
drivers/scsi/virtio_scsi.c