]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
mmc: sdhci-xenon: fix annoying 1.8V regulator warning
authorMarek Behún <marek.behun@nic.cz>
Mon, 20 Apr 2020 08:04:44 +0000 (10:04 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 25 May 2020 08:42:18 +0000 (10:42 +0200)
commit2189b3afa10a43e16c84b38d63601d92db186ecc
tree480281484ee33871abbf7986265d6e74276aee93
parentf1f5adf1cf55a6354bcec63f7391dfc9ec5c54da
mmc: sdhci-xenon: fix annoying 1.8V regulator warning

BugLink: https://bugs.launchpad.net/bugs/1877592
commit bb32e1987bc55ce1db400faf47d85891da3c9b9f upstream.

For some reason the Host Control2 register of the Xenon SDHCI controller
sometimes reports the bit representing 1.8V signaling as 0 when read
after it was written as 1. Subsequent read reports 1.

This causes the sdhci_start_signal_voltage_switch function to report
  1.8V regulator output did not become stable

When CONFIG_PM is enabled, the host is suspended and resumend many
times, and in each resume the switch to 1.8V is called, and so the
kernel log reports this message annoyingly often.

Do an empty read of the Host Control2 register in Xenon's
.voltage_switch method to circumvent this.

This patch fixes this particular problem on Turris MOX.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Fixes: 8d876bf472db ("mmc: sdhci-xenon: wait 5ms after set 1.8V...")
Cc: stable@vger.kernel.org # v4.16+
Link: https://lore.kernel.org/r/20200420080444.25242-1-marek.behun@nic.cz
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/mmc/host/sdhci-xenon.c