]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
sched: etf: Fix ordering of packets with same txtime
authorVinicius Costa Gomes <vinicius.gomes@intel.com>
Mon, 14 Oct 2019 20:38:22 +0000 (13:38 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 17:46:44 +0000 (18:46 +0100)
commit21a811977b3635330034ee01cbe38ae959f7d590
tree64a16856b8908ed5be7bf2813d2bf23b0003b095
parent3216f7c2b5215a0b04efa7e74383bda5a0b14890
sched: etf: Fix ordering of packets with same txtime

BugLink: https://bugs.launchpad.net/bugs/1850456
[ Upstream commit 28aa7c86c2b49f659c8460a89e53b506c45979bb ]

When a application sends many packets with the same txtime, they may
be transmitted out of order (different from the order in which they
were enqueued).

This happens because when inserting elements into the tree, when the
txtime of two packets are the same, the new packet is inserted at the
left side of the tree, causing the reordering. The only effect of this
change should be that packets with the same txtime will be transmitted
in the order they are enqueued.

The application in question (the AVTP GStreamer plugin, still in
development) is sending video traffic, in which each video frame have
a single presentation time, the problem is that when packetizing,
multiple packets end up with the same txtime.

The receiving side was rejecting packets because they were being
received out of order.

Fixes: 25db26a91364 ("net/sched: Introduce the ETF Qdisc")
Reported-by: Ederson de Souza <ederson.desouza@intel.com>
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
net/sched/sch_etf.c