]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
xfs: drop ->writepage completely
authorDave Chinner <dchinner@redhat.com>
Wed, 11 Aug 2021 01:33:41 +0000 (18:33 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 19 Aug 2021 01:45:59 +0000 (18:45 -0700)
commit21b4ee7029c9072d410e15f64840659241ba8f4a
treee923f9bf7d1ad078c83b495f596fb16e3440c181
parent33c0dd7898a11ef19169abe5c5049fa6aa099c64
xfs: drop ->writepage completely

->writepage is only used in one place - single page writeback from
memory reclaim. We only allow such writeback from kswapd, not from
direct memory reclaim, and so it is rarely used. When it comes from
kswapd, it is effectively random dirty page shoot-down, which is
horrible for IO patterns. We will already have background writeback
trying to clean all the dirty pages in memory as efficiently as
possible, so having kswapd interrupt our well formed IO stream only
slows things down. So get rid of xfs_vm_writepage() completely.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
[djwong: forward port to 5.15]
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/xfs/xfs_aops.c