]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK
authorRandy Dunlap <rdunlap@infradead.org>
Sun, 26 Sep 2021 17:12:24 +0000 (10:12 -0700)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 4 Jan 2022 08:48:15 +0000 (09:48 +0100)
commit2233f1f47f95063206154e775e7e1011dd006fa5
treea330367bdae56839e5d71a1cbbe035b18173b0ab
parentc1b1118ec220fd0ceaace15b52323b8487b12e6b
ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK

BugLink: https://bugs.launchpad.net/bugs/1951822
[ Upstream commit c15b5fc054c3d6c97e953617605235c5cb8ce979 ]

When CONFIG_PRINTK is not set, the CMPXCHG_BUGCHECK() macro calls
_printk(), but _printk() is a static inline function, not available
as an extern.
Since the purpose of the macro is to print the BUGCHECK info,
make this config option depend on PRINTK.

Fixes multiple occurrences of this build error:

../include/linux/printk.h:208:5: error: static declaration of '_printk' follows non-static declaration
  208 | int _printk(const char *s, ...)
      |     ^~~~~~~
In file included from ../arch/ia64/include/asm/cmpxchg.h:5,
../arch/ia64/include/uapi/asm/cmpxchg.h:146:28: note: previous declaration of '_printk' with type 'int(const char *, ...)'
  146 |                 extern int _printk(const char *fmt, ...);

Cc: linux-ia64@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Chris Down <chris@chrisdown.name>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
arch/ia64/Kconfig.debug