]> git.proxmox.com Git - mirror_qemu.git/commit
target-i386: check/enforce: Check all CPUID.80000001H.EDX bits
authorEduardo Habkost <ehabkost@redhat.com>
Fri, 4 Jan 2013 22:01:08 +0000 (20:01 -0200)
committerAndreas Färber <afaerber@suse.de>
Tue, 8 Jan 2013 20:03:44 +0000 (21:03 +0100)
commit227146259e8deb14b7b30e7718e61512e0f524a9
tree1fb864c76115fc73bbe4f21bbb816c0e421ab9ec
parent54830ff84df5d1fb182e91bf40e3d7c66c2559a4
target-i386: check/enforce: Check all CPUID.80000001H.EDX bits

I have no idea why PPRO_FEATURES was being ignored on the check of the
CPUID.80000001H.EDX bits. I believe it was a mistake, and it was
supposed to be ~(PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) or just
~CPUID_EXT2_AMD_ALIASES, because some time ago kvm_cpu_fill_host() used
the CPUID instruction directly (instead of
kvm_arch_get_supported_cpuid()).

But now kvm_cpu_fill_host() uses kvm_arch_get_supported_cpuid(), and
kvm_arch_get_supported_cpuid() returns all supported bits for
CPUID.80000001H.EDX, even the AMD aliases (that are explicitly copied
from CPUID.01H.EDX), so we can make the code check/enforce all the
CPUID.80000001H.EDX bits.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
target-i386/cpu.c