]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
sh_eth: uninline sh_eth_{write|read}()
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Sat, 12 Dec 2015 22:44:50 +0000 (01:44 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Dec 2015 21:25:21 +0000 (16:25 -0500)
commit2274d3753f6c5a885be4cfdf8b39ae2045ba6e30
tree8791149419c3b4797df05e470b4f14b1a5eb98a4
parentd856c16d8a2b5afbc28c130ce4f5a4acadb3021d
sh_eth: uninline sh_eth_{write|read}()

Commit 3365711df024 ("sh_eth: WARN on access to a register not implemented in
in  a particular chip") added WARN_ON() to sh_eth_{read|write}(), thus making
it  unacceptable for these functions to be *inline* anymore. Remove *inline*
and move the functions from the header to the driver itself. Below   is our
code economy with ARM gcc 4.7.3:

$ size drivers/net/ethernet/renesas/sh_eth.o{~,}
   text    data     bss     dec     hex filename
  32489    1140       0   33629    835d drivers/net/ethernet/renesas/sh_eth.o~
  25413    1140       0   26553    67b9 drivers/net/ethernet/renesas/sh_eth.o

Suggested-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/sh_eth.c
drivers/net/ethernet/renesas/sh_eth.h