]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
wait: using uninitialized member of wait queue
authorEvgeny Kuznetsov <ext-eugeny.kuznetsov@nokia.com>
Tue, 5 Oct 2010 08:47:57 +0000 (12:47 +0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 5 Oct 2010 18:47:18 +0000 (11:47 -0700)
commit231d0aefd88e94129cb8fb84794f9bb788c6366e
treea97313f61b394f93413a9025e72de05179c0ef65
parent5336377d6225959624146629ce3fc88ee8ecda3d
wait: using uninitialized member of wait queue

The "flags" member of "struct wait_queue_t" is used in several places in
the kernel code without beeing initialized by init_wait().  "flags" is
used in bitwise operations.

If "flags" not initialized then unexpected behaviour may take place.
Incorrect flags might used later in code.

Added initialization of "wait_queue_t.flags" with zero value into
"init_wait".

Signed-off-by: Evgeny Kuznetsov <EXT-Eugeny.Kuznetsov@nokia.com>
[ The bit we care about does end up being initialized by both
   prepare_to_wait() and add_to_wait_queue(), so this doesn't seem to
   cause actual bugs, but is definitely the right thing to do -Linus ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/wait.h