]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller
authorMatthias Kaehlcke <mka@chromium.org>
Wed, 2 Oct 2019 19:44:06 +0000 (12:44 -0700)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 29 Jan 2020 04:58:30 +0000 (23:58 -0500)
commit23a838710187e279c35662505a74b55cc1fd5fb0
treec37622c76609e543cd9308a3e03c745f3146819f
parenta210477895737431d61cc391bc04e691d212b803
drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

BugLink: https://bugs.launchpad.net/bugs/1860490
[ Upstream commit bee447e224b2645911c5d06e35dc90d8433fcef6 ]

The DDC/CI protocol involves sending a multi-byte request to the
display via I2C, which is typically followed by a multi-byte
response. The internal I2C controller only allows single byte
reads/writes or reads of 8 sequential bytes, hence DDC/CI is not
supported when the internal I2C controller is used. The I2C
transfers complete without errors, however the data in the response
is garbage. Abort transfers to/from slave address 0x37 (DDC) with
-EOPNOTSUPP, to make it evident that the communication is failing.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Sean Paul <sean@poorly.run>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191002124354.v2.1.I709dfec496f5f0b44a7b61dcd4937924da8d8382@changeid
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c