]> git.proxmox.com Git - mirror_qemu.git/commit
block: remove outdated AioContext locking comments
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 5 Dec 2023 18:20:11 +0000 (13:20 -0500)
committerKevin Wolf <kwolf@redhat.com>
Thu, 21 Dec 2023 21:49:27 +0000 (22:49 +0100)
commit23c983c8f6b2fea22698f501aa6a2c03dadd81ba
tree405001c138d88aa6aee3001243e467ba26a8b7bb
parente91083cd3f082c4d26a7d52268cbd57fc81def28
block: remove outdated AioContext locking comments

The AioContext lock no longer exists.

There is one noteworthy change:

  - * More specifically, these functions use BDRV_POLL_WHILE(bs), which
  - * requires the caller to be either in the main thread and hold
  - * the BlockdriverState (bs) AioContext lock, or directly in the
  - * home thread that runs the bs AioContext. Calling them from
  - * another thread in another AioContext would cause deadlocks.
  + * More specifically, these functions use BDRV_POLL_WHILE(bs), which requires
  + * the caller to be either in the main thread or directly in the home thread
  + * that runs the bs AioContext. Calling them from another thread in another
  + * AioContext would cause deadlocks.

I am not sure whether deadlocks are still possible. Maybe they have just
moved to the fine-grained locks that have replaced the AioContext. Since
I am not sure if the deadlocks are gone, I have kept the substance
unchanged and just removed mention of the AioContext.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-ID: <20231205182011.1976568-15-stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c
block/block-backend.c
block/export/vhost-user-blk-server.c
include/block/block-common.h
include/block/block-io.h
include/block/block_int-common.h
tests/qemu-iotests/202
tests/qemu-iotests/203