]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
perf script: Use readdir() instead of deprecated readdir_r()
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 8 Apr 2016 14:25:59 +0000 (11:25 -0300)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Fri, 11 Aug 2017 10:36:50 +0000 (12:36 +0200)
commit244ce0bff3abedd12e18daa1a96a19aa5551eff3
tree03100275a4c20df7bc229df3370d52389bbcd5d2
parent84d7e3fd58ae5dec8624a3c22fbd02e8cd3438fd
perf script: Use readdir() instead of deprecated readdir_r()

BugLink: http://bugs.launchpad.net/bugs/1705238
commit a5e8e825bd1704c488bf6a46936aaf3b9f203d6a upstream.

The readdir() function is thread safe as long as just one thread uses a
DIR, which is the case in 'perf script', so, to avoid breaking the build
with glibc-2.23.90 (upcoming 2.24), use it instead of readdir_r().

See: http://man7.org/linux/man-pages/man3/readdir.3.html

"However, in modern implementations (including the glibc implementation),
concurrent calls to readdir() that specify different directory streams
are thread-safe.  In cases where multiple threads must read from the
same directory stream, using readdir() with external synchronization is
still preferable to the use of the deprecated readdir_r(3) function."

Noticed while building on a Fedora Rawhide docker container.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-mt3xz7n2hl49ni2vx7kuq74g@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
tools/perf/builtin-script.c