]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
leds: lp5523: fix a missing check of return value of lp55xx_read
authorKangjie Lu <kjlu@umn.edu>
Wed, 26 Dec 2018 04:18:23 +0000 (22:18 -0600)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Thu, 17 Jan 2019 21:27:39 +0000 (22:27 +0100)
commit248b57015f35c94d4eae2fdd8c6febf5cd703900
tree880652e44f82321bb1c3130f2636b42ce80d2b2a
parentbfeffd155283772bbe78c6a05dec7c0128ee500c
leds: lp5523: fix a missing check of return value of lp55xx_read

When lp55xx_read() fails, "status" is an uninitialized variable and thus
may contain random value; using it leads to undefined behaviors.

The fix inserts a check for the return value of lp55xx_read: if it
fails, returns with its error code.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/leds-lp5523.c