]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
powerpc/watchdog: remove arch_trigger_cpumask_backtrace
authorNicholas Piggin <npiggin@gmail.com>
Wed, 11 Apr 2018 16:09:39 +0000 (12:09 -0400)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 12 Apr 2018 15:28:25 +0000 (10:28 -0500)
commit2518af4ba405c614f53419ad75e72a929608e56c
treee190bf2228cb253de866424d342e3cf97584e1b2
parent46064a7b8975e551d59803cbaa73223fb38655ed
powerpc/watchdog: remove arch_trigger_cpumask_backtrace

BugLink: http://bugs.launchpad.net/bugs/1762913
The powerpc NMI IPIs may not be recoverable if they are taken in
some sections of code, and also there have been and still are issues
with taking NMIs (in KVM guest code, in firmware, etc) which makes them
a bit dangerous to use.

Generic code like softlockup detector and rcu stall detectors really
hammer on trigger_*_backtrace, which has lead to further problems
because we've implemented it with the NMI.

So stop providing NMI backtraces for now. Importantly, the powerpc code
uses NMI IPIs in crash/debug, and the SMP hardlockup watchdog. So if the
softlockup and rcu hang detection traces are not being printed because
the CPU is stuck with interrupts off, then the hard lockup watchdog
should get it with the NMI IPI.

Fixes: 2104180a5369 ("powerpc/64s: implement arch-specific hardlockup watchdog")
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
(cherry picked from commit 47712a921bb781caf69fca9eae43be19968816cb)
Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
arch/powerpc/include/asm/nmi.h
arch/powerpc/kernel/watchdog.c