]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
crypto: pcbc - remove bogus memcpy()s with src == dest
authorEric Biggers <ebiggers@google.com>
Fri, 4 Jan 2019 04:16:13 +0000 (20:16 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 11 Jan 2019 06:16:57 +0000 (14:16 +0800)
commit251b7aea34ba3c4d4fdfa9447695642eb8b8b098
tree4e2b2ce50c7f79ac784abfc4332f2301d51cf4e9
parentb3e3e2db7de4a1ffe8845876c3520b866cd48de1
crypto: pcbc - remove bogus memcpy()s with src == dest

The memcpy()s in the PCBC implementation use walk->iv as both the source
and destination, which has undefined behavior.  These memcpy()'s are
actually unneeded, because walk->iv is already used to hold the previous
plaintext block XOR'd with the previous ciphertext block.  Thus,
walk->iv is already updated to its final value.

So remove the broken and unnecessary memcpy()s.

Fixes: 91652be5d1b9 ("[CRYPTO] pcbc: Add Propagated CBC template")
Cc: <stable@vger.kernel.org> # v2.6.21+
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/pcbc.c