]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
sched/tracing: Report TASK_RTLOCK_WAIT tasks as TASK_UNINTERRUPTIBLE
authorValentin Schneider <valentin.schneider@arm.com>
Thu, 20 Jan 2022 16:25:20 +0000 (16:25 +0000)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 1 Mar 2022 15:18:39 +0000 (16:18 +0100)
commit25795ef6299f07ce3838f3253a9cb34f64efcfae
tree8ca2a13144dc04b95650cccff0bd0ff6b5dc6814
parentfa2c3254d7cfff5f7a916ab928a562d1165f17bb
sched/tracing: Report TASK_RTLOCK_WAIT tasks as TASK_UNINTERRUPTIBLE

TASK_RTLOCK_WAIT currently isn't part of TASK_REPORT, thus a task blocking
on an rtlock will appear as having a task state == 0, IOW TASK_RUNNING.

The actual state is saved in p->saved_state, but reading it after reading
p->__state has a few issues:
o that could still be TASK_RUNNING in the case of e.g. rt_spin_lock
o ttwu_state_match() might have changed that to TASK_RUNNING

As pointed out by Eric, adding TASK_RTLOCK_WAIT to TASK_REPORT implies
exposing a new state to userspace tools which way not know what to do with
them. The only information that needs to be conveyed here is that a task is
waiting on an rt_mutex, which matches TASK_UNINTERRUPTIBLE - there's no
need for a new state.

Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Link: https://lore.kernel.org/r/20220120162520.570782-3-valentin.schneider@arm.com
include/linux/sched.h