]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
ASoC: rsnd: Add missing initialization of ADG req_rate
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 28 Oct 2015 15:03:48 +0000 (16:03 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 19 Sep 2017 09:07:24 +0000 (11:07 +0200)
commit25b2ddb75d77eb7bb63ac5a3e9e46c2d89da2096
treef88d44b70a19b73271a2c659b2bc2b0faf7a7968
parent7d08579cd6b9130fdbaece1eddbb556c8ae2f29c
ASoC: rsnd: Add missing initialization of ADG req_rate

BugLink: http://bugs.launchpad.net/bugs/1714298
commit 8b27418f300cafbdbbb8cfa9c29d398ed34d6723 upstream.

If the "clock-frequency" DT property is not found, req_rate is used
uninitialized, and the "audio_clkout" clock will be created with an
arbitrary clock rate.

This uninitialized kernel stack data may leak to userspace through
/sys/kernel/debug/clk/clk_summary, cfr. the value in the "rate" column:

       clock     enable_cnt  prepare_cnt        rate   accuracy   phase
    --------------------------------------------------------------------
     audio_clkout         0            0  4001836240          0 0

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Thong Ho <thong.ho.px@rvc.renesas.com>
Signed-off-by: Nhan Nguyen <nhan.nguyen.yb@renesas.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
sound/soc/sh/rcar/adg.c