]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
arm64: dts: qcom: sa8155p-adp: Specify which LDO modes are allowed
authorDouglas Anderson <dianders@chromium.org>
Mon, 29 Aug 2022 16:49:47 +0000 (09:49 -0700)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 14 Dec 2022 12:59:27 +0000 (13:59 +0100)
commit25fff7ebb2112d281a3109a3f709b572686fd625
treeb9512710e3843801d6a1d6940721fa9eb46ea5d0
parente00fd7bc4efbea3ac2717398f82c15f261c0a75f
arm64: dts: qcom: sa8155p-adp: Specify which LDO modes are allowed

[ Upstream commit bd9f3dcf42d943b53190f99bcdbcfe98a56ac4cd ]

This board uses RPMH, specifies "regulator-allow-set-load" for LDOs,
but doesn't specify any modes with "regulator-allowed-modes".

Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement
get_optimum_mode(), not set_load()") the above meant that we were able
to set either LPM or HPM mode. After that commit (and fixes [1]) we'll
be stuck at the initial mode. Discussion of this has resulted in the
decision that the old dts files were wrong and should be fixed to
fully restore old functionality.

Let's re-enable the old functionality by fixing the dts.

NOTE: while here, let's also remove the nonsensical
"regulator-allow-set-load" on the fixed regulator "vreg_s4a_1p8".

[1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid

Fixes: 5b85e8f2225c ("arm64: dts: qcom: sa8155p-adp: Add base dts file")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220829094903.v2.1.Id59c32b560c4662d8b3697de2bd494d08d654806@changeid
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit c8e76eeea77c9bca7453567ac1af761d108c2e70)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
arch/arm64/boot/dts/qcom/sa8155p-adp.dts