]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
f2fs: fix race in between GC and atomic open
authorChao Yu <yuchao0@huawei.com>
Tue, 17 Apr 2018 09:51:28 +0000 (17:51 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 1 Mar 2019 13:20:33 +0000 (14:20 +0100)
commit267aedc1eb6f93f4eb4928661157bf7630af50b5
tree1ad95e3677c4ad50070140a53b5da8424c454873
parent5a43171e1e4e9aeab9f99c7ef3686ec4b660c545
f2fs: fix race in between GC and atomic open

BugLink: http://bugs.launchpad.net/bugs/1815234
[ Upstream commit 27319ba4044c0c67d62ae39e53c0118c89f0a029 ]

Thread GC thread
- f2fs_ioc_start_atomic_write
 - get_dirty_pages
 - filemap_write_and_wait_range
- f2fs_gc
 - do_garbage_collect
  - gc_data_segment
   - move_data_page
    - f2fs_is_atomic_file
    - set_page_dirty
 - set_inode_flag(, FI_ATOMIC_FILE)

Dirty data page can still be generated by GC in race condition as
above call stack.

This patch adds fi->dio_rwsem[WRITE] in f2fs_ioc_start_atomic_write
to avoid such race.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
fs/f2fs/file.c