]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ARM: 9187/1: JIVE: fix return value of __setup handler
authorRandy Dunlap <rdunlap@infradead.org>
Sat, 12 Mar 2022 06:36:09 +0000 (07:36 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 13:19:41 +0000 (15:19 +0200)
commit26c1cc617878d6bc9eaca33cf9116f40477045ac
tree23498ccffcbce7453745882b404b37cae9a43c1a
parent3ccf91b5d2b51e8b7f5a13e774b7c3fc70d7ba62
ARM: 9187/1: JIVE: fix return value of __setup handler

BugLink: https://bugs.launchpad.net/bugs/1971497
[ Upstream commit 8b2360c7157b462c4870d447d1e65d30ef31f9aa ]

__setup() handlers should return 1 to obsolete_checksetup() in
init/main.c to indicate that the boot option has been handled.
A return of 0 causes the boot option/value to be listed as an Unknown
kernel parameter and added to init's (limited) argument or environment
strings. Also, error return codes don't mean anything to
obsolete_checksetup() -- only non-zero (usually 1) or zero.
So return 1 from jive_mtdset().

Fixes: 9db829f485c5 ("[ARM] JIVE: Initial machine support for Logitech Jive")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: patches@armlinux.org.uk
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
arch/arm/mach-s3c24xx/mach-jive.c