]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
proc: don't use FOLL_FORCE for reading cmdline and environment
authorLinus Torvalds <torvalds@linux-foundation.org>
Tue, 25 Oct 2016 02:00:44 +0000 (19:00 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 25 Oct 2016 02:00:44 +0000 (19:00 -0700)
commit272ddc8b37354c3fe111ab26d25e792629148eee
tree78d4280320fbee5b4b37a839023b6a9ba34865ef
parent07d9a380680d1c0eb51ef87ff2eab5c994949e69
proc: don't use FOLL_FORCE for reading cmdline and environment

Now that Lorenzo cleaned things up and made the FOLL_FORCE users
explicit, it becomes obvious how some of them don't really need
FOLL_FORCE at all.

So remove FOLL_FORCE from the proc code that reads the command line and
arguments from user space.

The mem_rw() function actually does want FOLL_FORCE, because gdd (and
possibly many other debuggers) use it as a much more convenient version
of PTRACE_PEEKDATA, but we should consider making the FOLL_FORCE part
conditional on actually being a ptracer.  This does not actually do
that, just moves adds a comment to that effect and moves the gup_flags
settings next to each other.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/proc/base.c