]> git.proxmox.com Git - mirror_qemu.git/commit
vhost-user-bridge: fix iov_restore_front() warning
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Fri, 2 Jun 2017 08:15:19 +0000 (12:15 +0400)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 8 Jun 2017 19:02:36 +0000 (22:02 +0300)
commit277238f9f41e0a429a24b05c03f3010b35c3e9d0
tree49836de6e617ae77f10ac9cd7d35f3b424dbd4b4
parent64175afc695c0672876fbbfc31b299c86d562cb4
vhost-user-bridge: fix iov_restore_front() warning

  CC      tests/vhost-user-bridge.o
/home/dgilbert/git/qemu-world3/tests/vhost-user-bridge.c:228:23: warning: variables 'front' and 'iov' used in loop condition not modified in loop body [-Wfor-loop-analysis]
    for (cur = front; front != iov; cur++) {
                      ^~~~~    ~~~
1 warning generated.

Fix the loop, document the function, and fix some related assert().

In practice, the loop bug was harmless because the front sg buffer is
enough to discard/restore the header size.

Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Tested-by: Jens Freimann <jfreiman@redhat.com>
tests/vhost-user-bridge.c