]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
tick/nohz: Use WARN_ON_ONCE() to prevent console saturation
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Mon, 6 Dec 2021 14:59:50 +0000 (09:59 -0500)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 27 Apr 2022 10:01:03 +0000 (12:01 +0200)
commit27a08dc13495e9a46e9eeb6b7a1e367dd83acf13
treef977ea61ebc25679ca521b090987da686b78e176
parent4351adb19ca890ca9c167d7d91edf68c480ffed5
tick/nohz: Use WARN_ON_ONCE() to prevent console saturation

BugLink: https://bugs.launchpad.net/bugs/1969857
commit 40e97e42961f8c6cc7bd5fe67cc18417e02d78f1 upstream.

While running some testing on code that happened to allow the variable
tick_nohz_full_running to get set but with no "possible" NOHZ cores to
back up that setting, this warning triggered:

        if (unlikely(tick_do_timer_cpu == TICK_DO_TIMER_NONE))
                WARN_ON(tick_nohz_full_running);

The console was overwhemled with an endless stream of one WARN per tick
per core and there was no way to even see what was going on w/o using a
serial console to capture it and then trace it back to this.

Change it to WARN_ON_ONCE().

Fixes: 08ae95f4fd3b ("nohz_full: Allow the boot CPU to be nohz_full")
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20211206145950.10927-3-paul.gortmaker@windriver.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
kernel/time/tick-sched.c