]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
nfc: Ensure presence of NFC_ATTR_FIRMWARE_NAME attribute in nfc_genl_fw_download()
authorDefang Bo <bodefang@126.com>
Mon, 19 Oct 2020 11:38:58 +0000 (19:38 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 21 Oct 2020 00:06:22 +0000 (17:06 -0700)
commit280e3ebdafb863b3cb50d5842f056267e15bf40c
treeeff2e1c1f6e5dead99c938c2b9d92485b569e705
parentb142083b585c2c03af24cca4d274f797796a4064
nfc: Ensure presence of NFC_ATTR_FIRMWARE_NAME attribute in nfc_genl_fw_download()

Check that the NFC_ATTR_FIRMWARE_NAME attributes are provided by
the netlink client prior to accessing them.This prevents potential
unhandled NULL pointer dereference exceptions which can be triggered
by malicious user-mode programs, if they omit one or both of these
attributes.

Similar to commit a0323b979f81 ("nfc: Ensure presence of required attributes in the activate_target handler").

Fixes: 9674da8759df ("NFC: Add firmware upload netlink command")
Signed-off-by: Defang Bo <bodefang@126.com>
Link: https://lore.kernel.org/r/1603107538-4744-1-git-send-email-bodefang@126.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/nfc/netlink.c