]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
dmaengine: at_hdmac: fix memory leak in at_dma_xlate()
authorRichard Genoud <richard.genoud@gmail.com>
Tue, 27 Nov 2018 16:06:34 +0000 (17:06 +0100)
committerSultan Alsawaf <sultan.alsawaf@canonical.com>
Wed, 24 Jul 2019 15:44:58 +0000 (09:44 -0600)
commit2834ed6e5dc206a488941e0ee4835a4ae52c388a
treead398111676cdb848378a596c481324cfe657ca5
parentacfc73b1879a615f43653e08ac25313c758fb233
dmaengine: at_hdmac: fix memory leak in at_dma_xlate()

BugLink: https://bugs.launchpad.net/bugs/1836968
commit 98f5f932254b88ce828bc8e4d1642d14e5854caa upstream.

The leak was found when opening/closing a serial port a great number of
time, increasing kmalloc-32 in slabinfo.

Each time the port was opened, dma_request_slave_channel() was called.
Then, in at_dma_xlate(), atslave was allocated with devm_kzalloc() and
never freed. (Well, it was free at module unload, but that's not what we
want).
So, here, kzalloc is more suited for the job since it has to be freed in
atc_free_chan_resources().

Cc: stable@vger.kernel.org
Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding")
Reported-by: Mario Forner <m.forner@be4energy.com>
Suggested-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/dma/at_hdmac.c