]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
drm/vkms: fix misuse of WARN_ON
authorDmitry Vyukov <dvyukov@google.com>
Sat, 20 Mar 2021 13:28:40 +0000 (14:28 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 19 May 2021 08:32:10 +0000 (10:32 +0200)
commit2852182125e213607b282b2b157b87bf7beffe5e
treedf95b60ae8d6b5cef430a0102d57768a1b60a01a
parentc3b55389b76ba6de45e8228a193976be52aea0fe
drm/vkms: fix misuse of WARN_ON

BugLink: https://bugs.launchpad.net/bugs/1928857
[ Upstream commit b4142fc4d52d051d4d8df1fb6c569e5b445d369e ]

vkms_vblank_simulate() uses WARN_ON for timing-dependent condition
(timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used
to denote kernel bugs. Use pr_warn() instead.

Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Reported-by: syzbot+4fc21a003c8332eb0bdd@syzkaller.appspotmail.com
Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Melissa Wen <melissa.srw@gmail.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Acked-by: Melissa Wen <melissa.srw@gmail.com>
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210320132840.1315853-1-dvyukov@google.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/gpu/drm/vkms/vkms_crtc.c