]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
Input: snvs_pwrkey - fix SNVS_HPVIDR1 register address
authorSebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Tue, 27 Sep 2022 14:15:45 +0000 (07:15 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 14 Nov 2022 10:25:23 +0000 (11:25 +0100)
commit28533015cb10c6fcabe38ef74505f7b91d40b149
treeed2e9a9d6af292707c900c619ada9fb15f90c7cf
parent2762b7f33a4fce77dde7258dbbca997de8add78e
Input: snvs_pwrkey - fix SNVS_HPVIDR1 register address

BugLink: https://bugs.launchpad.net/bugs/1995517
commit e62563db857f81d75c5726a35bc0180bed6d1540 upstream.

Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1
(chapters 57.9 and 6.4.5 respectively).

Without this, trying to read the revision number results in 0 on
all revisions, causing the i.MX6 quirk to apply on all platforms,
which in turn causes the driver to synthesise power button release
events instead of passing the real one as they happen even on
platforms like i.MX8 where that's not wanted.

Fixes: 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6 S, DL and Q")
Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/4599101.ElGaqSPkdT@pliszka
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/input/keyboard/snvs_pwrkey.c