]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
gpio: tegra: Fix tegra_gpio_irq_set_type()
authorDmitry Osipenko <digetx@gmail.com>
Tue, 17 Jul 2018 16:10:38 +0000 (19:10 +0300)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:51:44 +0000 (19:51 -0600)
commit2889b0900451fe9e69de318a5f353b10e898fcc1
tree302f39bfd759c80c05115372574577c0f58934a3
parent2363728b09ef4538c8fc5c5ddb5fd2fa9f5349bb
gpio: tegra: Fix tegra_gpio_irq_set_type()

BugLink: https://bugs.launchpad.net/bugs/1836287
[ Upstream commit f78709a5d4114edc21a5d86586ed5e56e284f2bd ]

Commit 36b312792b97 ("gpiolib: Respect error code of ->get_direction()")
broke tegra_gpio_irq_set_type() because requesting of GPIO direction must
be done after enabling GPIO function for a pin.

This patch fixes drivers probe failure like this:

 gpio gpiochip0: (tegra-gpio): gpiochip_lock_as_irq: cannot get GPIO direction
 tegra-gpio 6000d000.gpio: unable to lock Tegra GPIO 144 as IRQ

Fixes: 36b312792b97 ("gpiolib: Respect error code of ->get_direction()")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/gpio/gpio-tegra.c