]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
s390/qeth: reject oversized SNMP requests
authorJulian Wiedmann <jwi@linux.ibm.com>
Fri, 23 Aug 2019 09:29:23 +0000 (11:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 24 Aug 2019 23:34:08 +0000 (16:34 -0700)
commit292a50e3fc2cf699587ea282e6253e0d6ae3cdc1
treec40d909aa89da896c06a1e1924c06c762f3f12d8
parentb45ce32135d1c82a5bf12aa56957c3fd27956057
s390/qeth: reject oversized SNMP requests

Commit d4c08afafa04 ("s390/qeth: streamline SNMP cmd code") removed
the bounds checking for req_len, under the assumption that the check in
qeth_alloc_cmd() would suffice.

But that code path isn't sufficiently robust to handle a user-provided
data_length, which could overflow (when adding the cmd header overhead)
before being checked against QETH_BUFSIZE. We end up allocating just a
tiny iob, and the subsequent copy_from_user() writes past the end of
that iob.

Special-case this path and add a coarse bounds check, to protect against
maliciuous requests. This let's the subsequent code flow do its normal
job and precise checking, without risk of overflow.

Fixes: d4c08afafa04 ("s390/qeth: streamline SNMP cmd code")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core_main.c