]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 11 Jan 2018 11:21:51 +0000 (11:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Jan 2018 18:56:24 +0000 (13:56 -0500)
commit297a6961ffb8ff4dc66c9fbf53b924bd1dda05d5
treec9490ccc7020782fbe02187c85114135894a8dd6
parentecb10288a370b439e3b4552adea40d22900b9f64
net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe()

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mdio-bcm-unimac.c