]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ALSA: seq: Don't allow resizing pool in use
authorTakashi Iwai <tiwai@suse.de>
Mon, 5 Mar 2018 21:00:55 +0000 (22:00 +0100)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Thu, 15 Mar 2018 21:29:03 +0000 (18:29 -0300)
commit298318e4a4210ec9e80d3be10f4289a34940b0d8
tree72d320610d760625bcb8f33460d4a0459ba03391
parent3051e37890c6cf13bfeea0a540d44a6c5b1a2572
ALSA: seq: Don't allow resizing pool in use

BugLink: http://bugs.launchpad.net/bugs/1756100
commit d85739367c6d56e475c281945c68fdb05ca74b4c upstream.

This is a fix for a (sort of) fallout in the recent commit
d15d662e89fc ("ALSA: seq: Fix racy pool initializations") for
CVE-2018-1000004.
As the pool resize deletes the existing cells, it may lead to a race
when another thread is writing concurrently, eventually resulting a
UAF.

A simple workaround is not to allow the pool resizing when the pool is
in use.  It's an invalid behavior in anyway.

Fixes: d15d662e89fc ("ALSA: seq: Fix racy pool initializations")
Reported-by: 范龙飞 <long7573@126.com>
Reported-by: Nicolai Stange <nstange@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
sound/core/seq/seq_clientmgr.c