]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
workqueue: remove the stale comment in pwq_unbound_release_workfn()
authorLai Jiangshan <laijs@cn.fujitsu.com>
Tue, 22 Jul 2014 05:04:27 +0000 (13:04 +0800)
committerTejun Heo <tj@kernel.org>
Tue, 22 Jul 2014 16:10:39 +0000 (12:10 -0400)
commit29b1cb416a2920fbc70041e4382920ae2d86f426
treed0571f5bc0132f5a600c066e858a308b105dc729
parent13b1d625ef430ab7af059099828e1b9fba622369
workqueue: remove the stale comment in pwq_unbound_release_workfn()

In 75ccf5950f82 ("workqueue: prepare flush_workqueue() for dynamic
creation and destrucion of unbound pool_workqueues"), a comment
about the synchronization for the pwq in pwq_unbound_release_workfn()
was added. The comment claimed the flush_mutex wasn't strictly
necessary, it was correct in that time, due to the pwq was protected
by workqueue_lock.

But it is incorrect now since the wq->flush_mutex was renamed to
wq->mutex and workqueue_lock was removed, the wq->mutex is strictly
needed. But the comment was miss-updated when the synchronization
was changed.

This patch removes the incorrect comments and doesn't add any new
comment to explain why wq->mutex is needed here, which is definitely
obvious and wq->pwqs_node has "WQ" notation in its definition which is
better comment.

The old commit mentioned above also introduced a comment in link_pwq()
about the synchronization. This comment is also removed in this patch
since the whole link_pwq() is proteced by wq->mutex.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c