]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
usb: renesas_usbhs: Fix superfluous irqs happen after usb_pkt_pop()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Thu, 24 Jun 2021 12:20:39 +0000 (21:20 +0900)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Mon, 20 Sep 2021 16:49:37 +0000 (18:49 +0200)
commit2a75606c3d14089f9042b1733a31480bebb6b573
treec34031eed439a99464317b6e0b82ff91ea8ab371
parent1bb7b692ce523bd2c5aa6c8ca72f7722320d32b9
usb: renesas_usbhs: Fix superfluous irqs happen after usb_pkt_pop()

BugLink: https://bugs.launchpad.net/bugs/1939899
commit 5719df243e118fb343725e8b2afb1637e1af1373 upstream.

This driver has a potential issue which this driver is possible to
cause superfluous irqs after usb_pkt_pop() is called. So, after
the commit 3af32605289e ("usb: renesas_usbhs: fix error return
code of usbhsf_pkt_handler()") had been applied, we could observe
the following error happened when we used g_audio.

    renesas_usbhs e6590000.usb: irq_ready run_error 1 : -22

To fix the issue, disable the tx or rx interrupt in usb_pkt_pop().

Fixes: 2743e7f90dc0 ("usb: renesas_usbhs: fix the usb_pkt_pop()")
Cc: <stable@vger.kernel.org> # v4.4+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/20210624122039.596528-1-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/usb/renesas_usbhs/fifo.c