]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
KVM: x86/mmu: Use -1 to flag an undefined spte in get_mmio_spte()
authorSean Christopherson <seanjc@google.com>
Fri, 18 Dec 2020 00:31:36 +0000 (16:31 -0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 7 Jan 2021 23:00:23 +0000 (18:00 -0500)
commit2aa078932ff6c66bf10cc5b3144440dbfa7d813d
tree9e6c32d44dbdaf5162ef1dca29da1c2e227574ed
parent2c85ebc57b3e1817b6ce1a6b703928e113a90442
KVM: x86/mmu: Use -1 to flag an undefined spte in get_mmio_spte()

Return -1 from the get_walk() helpers if the shadow walk doesn't fill at
least one spte, which can theoretically happen if the walk hits a
not-present PDPTR.  Returning the root level in such a case will cause
get_mmio_spte() to return garbage (uninitialized stack data).  In
practice, such a scenario should be impossible as KVM shouldn't get a
reserved-bit page fault with a not-present PDPTR.

Note, using mmu->root_level in get_walk() is wrong for other reasons,
too, but that's now a moot point.

Fixes: 95fb5b0258b7 ("kvm: x86/mmu: Support MMIO in the TDP MMU")
Cc: Ben Gardon <bgardon@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20201218003139.2167891-2-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu/mmu.c
arch/x86/kvm/mmu/tdp_mmu.c