]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ASoC: SOF: topology: Fix bytes control size checks
authorDragos Tarcatu <dragos_tarcatu@mentor.com>
Wed, 6 Nov 2019 14:58:16 +0000 (08:58 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 6 Nov 2019 18:17:54 +0000 (18:17 +0000)
commit2acdcabb8a4089476208a822050dd47a6557290d
tree862d81c6895128207e81abf2edbb986aed985d7c
parent992fd39a349ac62044d9e20d17d309c2cf0f5c27
ASoC: SOF: topology: Fix bytes control size checks

When using the example SOF amp widget topology, KASAN dumps this
when the AMP bytes kcontrol gets loaded:

[ 9.579548] BUG: KASAN: slab-out-of-bounds in
sof_control_load+0x8cc/0xac0 [snd_sof]
[ 9.588194] Write of size 40 at addr ffff8882314559dc by task
systemd-udevd/2411

Fix that by rejecting the topology if the bytes data size > max_size

Fixes: 311ce4fe7637d ("ASoC: SOF: Add support for loading topologies")
Reviewed-by: Jaska Uimonen <jaska.uimonen@intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20191106145816.9367-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/topology.c