]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ALSA: usb-audio: fix sign unintended sign extension on left shifts
authorColin Ian King <colin.king@canonical.com>
Thu, 27 Jun 2019 16:43:08 +0000 (17:43 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 28 Jun 2019 08:37:34 +0000 (10:37 +0200)
commit2acf5a3e6e9371e63c9e4ff54d84d08f630467a0
tree315a683f95aed870a72f6e1b3148059132915985
parent503d90b30602a3295978e46d844ccc8167400fe6
ALSA: usb-audio: fix sign unintended sign extension on left shifts

There are a couple of left shifts of unsigned 8 bit values that
first get promoted to signed ints and hence get sign extended
on the shift if the top bit of the 8 bit values are set. Fix
this by casting the 8 bit values to unsigned ints to stop the
unintentional sign extension.

Addresses-Coverity: ("Unintended sign extension")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer_quirks.c