]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/mediatek: fix possible object reference leak
authorWen Yang <wen.yang99@zte.com.cn>
Wed, 3 Apr 2019 16:04:09 +0000 (00:04 +0800)
committerCK Hu <ck.hu@mediatek.com>
Tue, 9 Apr 2019 05:09:43 +0000 (13:09 +0800)
commit2ae2c3316fb77dcf64275d011596b60104c45426
treec8f0e29041f88284ba1ceb703b829ab5a4d3e82c
parent2d85978341e6a32e7443d9f28639da254d53f400
drm/mediatek: fix possible object reference leak

The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
drivers/gpu/drm/mediatek/mtk_hdmi.c:1521:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1509, but without a corresponding object release within this function.
drivers/gpu/drm/mediatek/mtk_hdmi.c:1524:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1509, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: CK Hu <ck.hu@mediatek.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: CK Hu <ck.hu@mediatek.com>
drivers/gpu/drm/mediatek/mtk_hdmi.c