]> git.proxmox.com Git - mirror_qemu.git/commit
vhost: restore avail index from vring used index on disconnection
authorMaxime Coquelin <maxime.coquelin@redhat.com>
Thu, 16 Nov 2017 18:48:35 +0000 (19:48 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Fri, 1 Dec 2017 17:05:58 +0000 (19:05 +0200)
commit2ae39a113af311cb56a0c35b7f212dafcef15303
tree086a5a3cc0169ca75cf8addca82f7119d0681ee4
parent2d4ba6cc741df15df6fbb4feaa706a02e103083a
vhost: restore avail index from vring used index on disconnection

vhost_virtqueue_stop() gets avail index value from the backend,
except if the backend is not responding.

It happens when the backend crashes, and in this case, internal
state of the virtio queue is inconsistent, making packets
to corrupt the vring state.

With a Linux guest, it results in following error message on
backend reconnection:

[   22.444905] virtio_net virtio0: output.0:id 0 is not a head!
[   22.446746] net enp0s3: Unexpected TXQ (0) queue failure: -5
[   22.476360] net enp0s3: Unexpected TXQ (0) queue failure: -5

Fixes: 283e2c2adcb8 ("net: virtio-net discards TX data after link down")
Cc: qemu-stable@nongnu.org
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/virtio/vhost.c