]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ALSA: rawmidi: Fix potential Spectre v1 vulnerability
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 20 Mar 2019 21:15:24 +0000 (16:15 -0500)
committerTakashi Iwai <tiwai@suse.de>
Thu, 21 Mar 2019 12:21:15 +0000 (13:21 +0100)
commit2b1d9c8f87235f593826b9cf46ec10247741fff9
treec592769a24939ce800b7038fa4faba8908679506
parent667a8f73753908c4d0171e52b71774f9be5d6713
ALSA: rawmidi: Fix potential Spectre v1 vulnerability

info->stream is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

sound/core/rawmidi.c:604 __snd_rawmidi_info_select() warn: potential spectre issue 'rmidi->streams' [r] (local cap)

Fix this by sanitizing info->stream before using it to index
rmidi->streams.

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://lore.kernel.org/lkml/20180423164740.GY17484@dhcp22.suse.cz/

Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/rawmidi.c