]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
led: core: Fix brightness setting when setting delay_off=0
authorMatthieu CASTET <matthieu.castet@parrot.com>
Tue, 12 Dec 2017 10:10:44 +0000 (11:10 +0100)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Wed, 27 Dec 2017 19:45:07 +0000 (20:45 +0100)
commit2b83ff96f51d0b039c4561b9f95c824d7bddb85c
tree931cbdf5b56e15e191a7ccf449aa126f3f5b30ea
parent4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323
led: core: Fix brightness setting when setting delay_off=0

With the current code, the following sequence won't work :
echo timer > trigger

echo 0 >  delay_off
* at this point we call
** led_delay_off_store
** led_blink_set
*** stop timer
** led_blink_setup
** led_set_software_blink
*** if !delay_on, led off
*** if !delay_off, set led_set_brightness_nosleep <--- LED_BLINK_SW is set but timer is stop
*** otherwise start timer/set LED_BLINK_SW flag

echo xxx > brightness
* led_set_brightness
** if LED_BLINK_SW
*** if brightness=0, led off
*** else apply brightness if next timer <--- timer is stop, and will never apply new setting
** otherwise set led_set_brightness_nosleep

To fix that, when we delete the timer, we should clear LED_BLINK_SW.

Cc: linux-leds@vger.kernel.org
Signed-off-by: Matthieu CASTET <matthieu.castet@parrot.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/led-core.c