]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
x86: Make sure get_user_desc() doesn't sign extend.
authorChris Lalancette <clalance@redhat.com>
Thu, 5 Nov 2009 10:47:08 +0000 (11:47 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 5 Nov 2009 21:22:18 +0000 (13:22 -0800)
commit2c75910f1aa042be1dd769378d2611bf551721ac
tree666448ea8a892c749851f2191b612c79f21f056c
parent9a6fc8d0f8c3ee3d42417e8315fc8c8fae1d3213
x86: Make sure get_user_desc() doesn't sign extend.

The current implementation of get_user_desc() sign extends the return
value because of integer promotion rules.  For the most part, this
doesn't matter, because the top bit of base2 is usually 0.  If, however,
that bit is 1, then the entire value will be 0xffff...  which is
probably not what the caller intended.

This patch casts the entire thing to unsigned before returning, which
generates almost the same assembly as the current code but replaces the
final "cltq" (sign extend) with a "mov %eax %eax" (zero-extend).  This
fixes booting certain guests under KVM.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/x86/include/asm/desc.h