]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: macb: use phy_interface_mode_is_rgmii everywhere
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 17 Jul 2020 23:32:21 +0000 (01:32 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 18 Jul 2020 01:32:35 +0000 (18:32 -0700)
commit2ccb0161a0e9eb06f538557d38987e436fc39b8d
treecf04d853a4c8e33bfbbb75038a2b833e83ebb4aa
parent23e500e88723f243c27e1b26c9d035d4cdd1b24a
net: macb: use phy_interface_mode_is_rgmii everywhere

There is one RGMII check not using the phy_interface_mode_is_rgmii()
helper. This prevents the driver from configuring the MAC properly when
using a phy-mode that is not just rgmii, e.g. rgmii-rxid. This became an
issue on sama5d3 xplained since the ksz9031 driver is hadling phy-mode
properly and the phy-mode has to be set to rgmii-rxid.

Fixes: bcf3440c6dd78bfe ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/macb_main.c