]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
netfilter: nf_tables: free flowtable hooks on hook register error
authorFlorian Westphal <fw@strlen.de>
Mon, 2 Mar 2020 20:58:50 +0000 (21:58 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 4 Mar 2020 01:27:18 +0000 (02:27 +0100)
commit2d285f26ecd072800a29c5b71e63437f21ef830a
tree3977efbf75e00c7c57bb970e89dd59cf07713926
parentee84f19cbbe9cf7cba2958acb03163fed3ecbb0f
netfilter: nf_tables: free flowtable hooks on hook register error

If hook registration fails, the hooks allocated via nft_netdev_hook_alloc
need to be freed.

We can't change the goto label to 'goto 5' -- while it does fix the memleak
it does cause a warning splat from the netfilter core (the hooks were not
registered).

Fixes: 3f0465a9ef02 ("netfilter: nf_tables: dynamically allocate hooks per net_device in flowtables")
Reported-by: syzbot+a2ff6fa45162a5ed4dd3@syzkaller.appspotmail.com
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c