]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
blktrace: Remove blk_fill_rwbs_rq.
authorTao Ma <boyu.mt@taobao.com>
Thu, 3 Mar 2011 15:53:20 +0000 (10:53 -0500)
committerJens Axboe <jaxboe@fusionio.com>
Thu, 3 Mar 2011 15:53:20 +0000 (10:53 -0500)
commit2d3a8497f8cc5aca14b722cd37d51f6c15ff9f74
tree2e0013fdc1eec486a425e666a885b04a1c37befb
parent255bb490c8c27eed484d538efe6ef6a7473bd3f6
blktrace: Remove blk_fill_rwbs_rq.

If we enable trace events to trace block actions, We use
blk_fill_rwbs_rq to analyze the corresponding actions
in request's cmd_flags, but we only choose the minor 2 bits
from it, so most of other flags(e.g, REQ_SYNC) are missing.
For example, with a sync write we get:
write_test-2409  [001]   160.013869: block_rq_insert: 3,64 W 0 () 258135 + =
8 [write_test]

Since now we have integrated the flags of both bio and request,
it is safe to pass rq->cmd_flags directly to blk_fill_rwbs and
blk_fill_rwbs_rq isn't needed any more.

With this patch, after a sync write we get:
write_test-2417  [000]   226.603878: block_rq_insert: 3,64 WS 0 () 258135 +=
 8 [write_test]

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
include/linux/blktrace_api.h
include/trace/events/block.h
kernel/trace/blktrace.c