]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
selftests/resctrl: Fix checking for < 0 for unsigned values
authorFenghua Yu <fenghua.yu@intel.com>
Wed, 17 Mar 2021 02:22:54 +0000 (02:22 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 19 May 2021 08:32:12 +0000 (10:32 +0200)
commit2d684368d7795c7e52a111e9e01e56afc56296cb
tree6e4808e2d73bd4eeb0ec5100484efe7877a385da
parentbadbe0acbeef79d36eb403c8b118674f397cab40
selftests/resctrl: Fix checking for < 0 for unsigned values

BugLink: https://bugs.launchpad.net/bugs/1928857
[ Upstream commit 1205b688c92558a04d8dd4cbc2b213e0fceba5db ]

Dan reported following static checker warnings

tools/testing/selftests/resctrl/resctrl_val.c:545 measure_vals()
warn: 'bw_imc' unsigned <= 0

tools/testing/selftests/resctrl/resctrl_val.c:549 measure_vals()
warn: 'bw_resc_end' unsigned <= 0

These warnings are reported because
1. measure_vals() declares 'bw_imc' and 'bw_resc_end' as unsigned long
   variables
2. Return value of get_mem_bw_imc() and get_mem_bw_resctrl() are assigned
   to 'bw_imc' and 'bw_resc_end' respectively
3. The returned values are checked for <= 0 to see if the calls failed

Checking for < 0 for an unsigned value doesn't make any sense.

Fix this issue by changing the implementation of get_mem_bw_imc() and
get_mem_bw_resctrl() such that they now accept reference to a variable
and set the variable appropriately upon success and return 0, else return
< 0 on error.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
tools/testing/selftests/resctrl/resctrl_val.c