]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
blk-mq: don't add non-pt request with ->end_io to batch
authorMing Lei <ming.lei@redhat.com>
Thu, 27 Oct 2022 08:57:09 +0000 (16:57 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 27 Oct 2022 13:15:44 +0000 (07:15 -0600)
commit2d87d455ead2cbdee7e60463cddc5bff3f98c912
tree8aea8eae84f797a115d2e2e3508c207d80c31017
parent7f21735ffb2648a29e0fc79c4bdcb1b9ed8602cd
blk-mq: don't add non-pt request with ->end_io to batch

dm-rq implements ->end_io callback for request issued to underlying queue,
and it isn't passthrough request.

Commit ab3e1d3bbab9 ("block: allow end_io based requests in the completion
batch handling") doesn't clear rq->bio and rq->__data_len for request
with ->end_io in blk_mq_end_request_batch(), and this way is actually
dangerous, but so far it is only for nvme passthrough request.

dm-rq needs to clean up remained bios in case of partial completion,
and req->bio is required, then use-after-free is triggered, so the
underlying clone request can't be completed in blk_mq_end_request_batch.

Fix panic by not adding such request into batch list, and the issue
can be triggered simply by exposing nvme pci to dm-mpath simply.

Fixes: ab3e1d3bbab9 ("block: allow end_io based requests in the completion batch handling")
Cc: dm-devel@redhat.com
Cc: Mike Snitzer <snitzer@kernel.org>
Reported-by: Changhui Zhong <czhong@redhat.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20221027085709.513175-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/blk-mq.h