]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: sctp: sctp_association_init: put refs in reverse order
authorDaniel Borkmann <dborkman@redhat.com>
Fri, 14 Jun 2013 16:24:07 +0000 (18:24 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 14 Jun 2013 22:38:36 +0000 (15:38 -0700)
commit2e0c9e7911465b29daf85f7de97949004bf7b31c
tree38d0346af3293be48c9ec687ab28ce425007ef20
parentc164b8381496ca797c37671fe510a264412ccae5
net: sctp: sctp_association_init: put refs in reverse order

In case we need to bail out for whatever reason during assoc
init, we call sctp_endpoint_put() and then sock_put(), however,
we've hold both refs in reverse, non-symmetric order, so first
sctp_endpoint_hold() and then sock_hold().

Reverse this, so that in an error case we have sock_put() and then
sctp_endpoint_put(). Actually shouldn't matter too much, since both
cleanup paths do the right thing, but that way, it is more consistent
with the rest of the code.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/associola.c