]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
sctp: remove sched init from sctp_stream_init
authorXin Long <lucien.xin@gmail.com>
Fri, 8 Mar 2019 07:49:16 +0000 (15:49 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Mar 2019 19:24:33 +0000 (11:24 -0800)
commit2e990dfd13974d9eae493006f42ffb48707970ef
treee7a67cb4b585a70221c095359967e47177871dce
parentee60ad219f5c7c4fb2f047f88037770063ef785f
sctp: remove sched init from sctp_stream_init

syzbot reported a NULL-ptr deref caused by that sched->init() in
sctp_stream_init() set stream->rr_next = NULL.

  kasan: GPF could be caused by NULL-ptr deref or user memory access
  RIP: 0010:sctp_sched_rr_dequeue+0xd3/0x170 net/sctp/stream_sched_rr.c:141
  Call Trace:
    sctp_outq_dequeue_data net/sctp/outqueue.c:90 [inline]
    sctp_outq_flush_data net/sctp/outqueue.c:1079 [inline]
    sctp_outq_flush+0xba2/0x2790 net/sctp/outqueue.c:1205

All sched info is saved in sout->ext now, in sctp_stream_init()
sctp_stream_alloc_out() will not change it, there's no need to
call sched->init() again, since sctp_outq_init() has already
done it.

Fixes: 5bbbbe32a431 ("sctp: introduce stream scheduler foundations")
Reported-by: syzbot+4c9934f20522c0efd657@syzkaller.appspotmail.com
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/stream.c